fix: add transaction() to Database interface#584
Open
ductiletoaster wants to merge 1 commit intotobi:mainfrom
Open
fix: add transaction() to Database interface#584ductiletoaster wants to merge 1 commit intotobi:mainfrom
ductiletoaster wants to merge 1 commit intotobi:mainfrom
Conversation
The custom Database interface in db.ts was missing the transaction() method, causing TypeScript compilation to fail on store.ts line 2142. Both better-sqlite3 and bun:sqlite support transaction(), so this was simply an omission in the interface definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The custom
Databaseinterface insrc/db.tsis missing thetransaction()method. This causes a TypeScript compilation error when building from source:The published npm package works because it ships pre-built
dist/files. But building from a fresh git clone fails.Fix
Add
transaction()to theDatabaseinterface:Both
better-sqlite3andbun:sqlitesupporttransaction(), so this is simply an omission in the interface definition.Verified