This repository was archived by the owner on Jan 2, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 82
New resource-based API #119
Open
tobyzerner
wants to merge
45
commits into
master
Choose a base branch
from
resource-interface
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
3d61e47
New resource-based API
tobyzerner 6494584
Merge branch 'master' into resource-interface
tobyzerner f395b01
Apply fixes from StyleCI
tobyzerner 1795c83
Merge pull request #120 from tobscure/analysis-qJbw7o
tobyzerner ba8a379
Only pull a resource out of the map if it exists
tobyzerner d25a3f4
Remove some methods from public API
tobyzerner 4e80ea8
Decode pagination link query string (no reason for it to be encoded)
tobyzerner 5430fba
Update ResourceInterface docblocks
tobyzerner 2ab0ac2
Rewrite tests
tobyzerner 946cc45
Apply fixes from StyleCI
tobyzerner 820e516
Merge pull request #122 from tobscure/analysis-XNwgj1
tobyzerner 6f9cf92
Drop support for PHPUnit 5.0 for now
tobyzerner 24f092d
Update README
tobyzerner a350d25
Add some missing docs
tobyzerner 0d66e3b
Formatting
tobyzerner ea20221
Add sparse fieldsets to example
tobyzerner 2a3c32a
Tweak wording
tobyzerner cb7702e
More tweaks
tobyzerner c7b8a32
Revert "Decode pagination link query string (no reason for it to be e…
tobyzerner 880a28d
Reverse non-encoding of pagination URLs (should've read the spec more…
tobyzerner ac96c04
Support page[size] in pagination links
tobyzerner a071a76
Improve README; add references to JSON-API spec
tobyzerner 44ed154
New error handling API in README (not implemented yet)
tobyzerner 4ad47d1
README: Make link methods more explicit, add Link objects (not implem…
tobyzerner 3321513
README: Simplify new error handling API: less magic, less surface area
tobyzerner 27a25b5
Formatting
tobyzerner afa7d3f
Formatting
tobyzerner 2f15ded
Formatting
tobyzerner 8c2a260
Tweaks
tobyzerner b9923e3
Add default error response for ease
tobyzerner ffa2bf8
Big changes
tobyzerner 9cf8336
Apply fixes from StyleCI
tobyzerner ed3d163
Merge pull request #123 from tobscure/analysis-qJ4m9Q
tobyzerner d1a008f
Relationship static constructors
tobyzerner a39459d
Apply fixes from StyleCI
tobyzerner 1c93c27
Merge pull request #124 from tobscure/analysis-XaLlmW
tobyzerner d50ba8a
More big changes, hopefully the last lot
tobyzerner e940b9f
Apply fixes from StyleCI
tobyzerner 6878c9c
Merge pull request #125 from tobscure/analysis-Xl91rQ
tobyzerner 6bf5873
Fix failing test
tobyzerner de73055
Fix Relationship constructors
tobyzerner 10adcf3
DRY-ed up tests
f3ath 47e8d6d
Merge pull request #134 from f3ath/dry-up-tests
tobyzerner 50ffec7
Added a benchmark
f3ath a0ddfe4
Merge pull request #141 from f3ath/benchmarks
tobyzerner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm proposing to name method more verbose (because we will pass
Resource
there):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also pass in an array of resources.
fromData
matches with the top-leveldata
key in the resulting document.