Skip to content

chore: apply eslint-driven linting & formatting across the codebase#59

Merged
toddeTV merged 11 commits into
mainfrom
chore/lint-codebase-for-eslint
May 3, 2026
Merged

chore: apply eslint-driven linting & formatting across the codebase#59
toddeTV merged 11 commits into
mainfrom
chore/lint-codebase-for-eslint

Conversation

@toddeTV
Copy link
Copy Markdown
Owner

@toddeTV toddeTV commented May 3, 2026

Summary by CodeRabbit

  • Style

    • Consolidated Tailwind CSS utility classes for improved consistency (e.g., size-5 instead of h-5 w-5).
    • Reformatted code styling across components and utilities for consistency.
  • Chores

    • Reordered configuration sections in Docker Compose and Nuxt config.
    • Updated TypeScript configuration references.

Note: This release contains internal code maintenance and formatting improvements with no impact on user-facing functionality.

@toddeTV toddeTV self-assigned this May 3, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

📝 Walkthrough

Walkthrough

This PR applies formatting and styling standardizations across the codebase: Tailwind utilities are consolidated (e.g., h-5 w-5size-5), array and destructuring syntax is reformatted to multi-line, and configuration file sections are reordered. No functional logic or runtime behavior is altered.

Changes

Tailwind & UI Styling Updates

Layer / File(s) Summary
Tailwind Utility Consolidation & Reordering
app/assets/css/main.css
body and scrollbar pseudo-element @apply directives are reordered; border and background utilities are repositioned while keeping the same set.
Size Utility Standardization
app/components/app/AppFooter.vue, app/components/ui/UiRadioOption.vue, app/pages/admin/results.vue
SVG and input element sizing classes updated from h-5 w-5 to size-5 throughout.
Border & Size Class Updates
app/pages/index.vue
h-16 w-16size-16 for emoji button, h-4 w-4size-4 for pulse dots, and border-[4px]border-4 for multiple container borders.
Fixed Positioning Shorthand
app/components/DebugWebsockets.vue
Debug panel positioning refactored from bottom-0 left-0 right-0 to inset-x-0 bottom-0.

Code Formatting & Array/Destructuring Refactoring

Layer / File(s) Summary
Multi-line Array Literals
app/pages/index.vue, app/pages/admin/questions.vue, app/utils/seededShuffle.ts, server/api/results/leaderboard.get.ts, server/utils/auth.ts, server/utils/storage.ts, shared/utils/validation.ts
Array initialization, spread operators, and segmenter results reformatted from single-line to multi-line literals.
Destructuring Formatting
server/api/questions/create.post.ts, server/api/results/leaderboard.get.ts, server/utils/websocket.ts, server/utils/storage.ts
Tuple and array destructuring in for...of and map operations expanded across multiple lines; logic remains unchanged.
Validation & Utility Refactoring
server/utils/websocket.ts
getPeers constructs intermediate targetEntries array and refactors destructuring; broadcast recipient set logic unchanged.
Form State Initialization Formatting
app/pages/admin/questions.vue
Default newQuestion.answer_options and form reset converted to multi-line array format; note parsing validation line-wrapped.

Configuration File Organization

Layer / File(s) Summary
Docker Compose Section Reordering
docker-compose.yml
networks definition moved before services; app service environment reordered; all values and configuration remain unchanged.
Nuxt Config Key Reordering
nuxt.config.ts
Top-level and nested config keys (modules, devtools, css, ssr, nitro, runtimeConfig) reordered without altering values or functionality.
TypeScript Config References
tsconfig.json
Added explicit ./.nuxt/tsconfig.node.json reference to references array with formatting adjustments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: applying ESLint-driven linting and formatting across the entire codebase, which matches the pattern of formatting changes (Tailwind utility reordering, multi-line array literals, spacing adjustments) evident in all modified files.
Docstring Coverage ✅ Passed Docstring coverage is 83.33% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 3/5 reviews remaining, refill in 18 minutes and 18 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@nuxt.config.ts`:
- Around line 53-58: The runtimeConfig currently contains hardcoded secrets
(adminPassword, adminUsername, jwtSecret) — replace these literal values by
sourcing them from environment variables (e.g., ADMIN_PASSWORD, ADMIN_USERNAME,
JWT_SECRET) and fall back to a safe default or throw on missing values; update
the runtimeConfig object (the runtimeConfig symbol in nuxt.config.ts) to read
from process.env (or the Nuxt runtime env helper) for adminPassword,
adminUsername and jwtSecret and ensure you update .env.example to document the
new variables and remove the hardcoded values.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 4f9bc340-5b41-4daa-a4cc-a90b5607fb27

📥 Commits

Reviewing files that changed from the base of the PR and between d7a3963 and 75ce502.

📒 Files selected for processing (17)
  • app/assets/css/main.css
  • app/components/DebugWebsockets.vue
  • app/components/app/AppFooter.vue
  • app/components/ui/UiRadioOption.vue
  • app/pages/admin/questions.vue
  • app/pages/admin/results.vue
  • app/pages/index.vue
  • app/utils/seededShuffle.ts
  • docker-compose.yml
  • nuxt.config.ts
  • server/api/questions/create.post.ts
  • server/api/results/leaderboard.get.ts
  • server/utils/auth.ts
  • server/utils/storage.ts
  • server/utils/websocket.ts
  • shared/utils/validation.ts
  • tsconfig.json

Comment thread nuxt.config.ts
@toddeTV toddeTV merged commit de80fdd into main May 3, 2026
5 checks passed
@toddeTV toddeTV deleted the chore/lint-codebase-for-eslint branch May 3, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant