Skip to content

Conversation

@serjan-nasredin
Copy link

It seemed strange to me that there is a nav tag in the footer tag.

@floitsch floitsch requested a review from enyo December 17, 2021 17:33
@enyo
Copy link
Contributor

enyo commented Jan 5, 2022

Hey @snxx-lppxx thx for the PR. Although a <nav> is perfectly fine inside a <footer> it's true that it's probably overly verbose (and mozilla actually lists this as an example where a <nav> is not necessary). But I'm not too happy having the <section> in there either since it's already in a <footer> element which is redundant. If you change the <section> to a <div class="footer"> I'd be happy to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants