Skip to content

feat: add crit fetch command for two-way review workflow#209

Merged
tomasz-tomczyk merged 1 commit intomainfrom
feat/crit-fetch
Mar 27, 2026
Merged

feat: add crit fetch command for two-way review workflow#209
tomasz-tomczyk merged 1 commit intomainfrom
feat/crit-fetch

Conversation

@tomasz-tomczyk
Copy link
Copy Markdown
Owner

Summary

  • Add crit fetch command that pulls web reviewer comments into local .crit.json
  • Fix appendReply to search all ReviewComments regardless of ID prefix (web-fetched IDs use web-N, not r)
  • Fix web-N counter to use max-finding to prevent duplicate IDs after comment deletion
  • Fix UTF-8 safe body truncation using []rune
  • Include review-scope comments in share payloads (initial and upsert)

Review

  • Code review: passed
  • Parity audit: N/A (CLI-only changes)

Test plan

🤖 Generated with Claude Code

- Add `crit fetch` command that pulls web reviewer comments into .crit.json
- Fix appendReply to search all ReviewComments (not just "r" prefix IDs)
- Fix web-N ID assignment to use max-finding to prevent duplicates after deletion
- Fix UTF-8 safe truncation in comment body preview using []rune
- Include review-scope comments in initial share and upsert payloads
- Add Scope field to shareComment with omitempty for review-scope serialization

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
@tomasz-tomczyk tomasz-tomczyk merged commit bc5f260 into main Mar 27, 2026
2 checks passed
@tomasz-tomczyk tomasz-tomczyk deleted the feat/crit-fetch branch March 27, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant