refactor: post-v0.7.0 release audit fixes#212
Merged
tomasz-tomczyk merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
Go: - Remove dead loadExistingShareState (replaced by loadExistingShareCfg) - Add AuthToken to configPresence so project config can clear global token - Route all .crit.json writes through saveCritJSON (consistent trailing newline) - Load config once per command, pass to resolveShareURL/resolveAuthToken Frontend: - Define --fg CSS var (= --fg-primary) in all 4 theme blocks; fixes hover states - Reset navCommentId on scope change, comment delete, session reload - Add :focus-visible outline to comment-nav buttons - Cancel pending nav highlight timer before setting new one (race fix) - Extract shared .toggle-btn base CSS; remove ~50 lines of duplication - Clear scope toggle disabled state on session reload Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadExistingShareState(replaced byloadExistingShareCfg), update testsAuthTokentoconfigPresenceso project config can clear a global token.crit.jsonwrites throughsaveCritJSONfor consistent trailing newlineresolveShareURL/resolveAuthToken(no double parse)--fgCSS var (=--fg-primary) in all 4 theme blocks — fixes hover colors in dark modenavCommentIdon scope change, comment delete, and session reload:focus-visibleoutline to comment-nav[/]buttonsclearTimeoutbefore each navigation.toggle-btnbase CSS (~50 lines removed)disabledstate on session reloadReview
Test plan
go test ./...— clean🤖 Generated with Claude Code