feat(omnibox): allow choosing download mode for batch downloads#182
Open
Crayz129 wants to merge 1 commit into
Open
feat(omnibox): allow choosing download mode for batch downloads#182Crayz129 wants to merge 1 commit into
Crayz129 wants to merge 1 commit into
Conversation
The batch download flow already forwarded `downloadMode` to the backend, but the mode selector was only rendered in the single-download state, so users could not pick "Audio only" (or "No sound") when pasting multiple URLs. This is especially noticeable with YouTube Music links, which are detected as regular YouTube videos. Render the existing DownloadModeSelector above "Download all" in the batch state, bound to the same `downloadMode` state that `handleBatchDownload` already reads. Also make DownloadModeSelector's `onChange` prop optional, since the batch usage has no format selection to reset. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When pasting multiple URLs, the batch download UI only shows "Download all" — there's no way to choose the download mode. So batch downloads always use whatever
downloadModehappens to be set, and you can't force "Audio only". This is especially noticeable with YouTube Music links (music.youtube.com), which are detected as regular YouTube videos: in single-download you can pick "Audio Only (MP3)", but in batch you can't.Fix
The batch flow already forwards
downloadModeto the backend (handleBatchDownload) — only the UI to choose it was missing. This renders the existingDownloadModeSelector(Auto / Audio Only / No Sound) above the "Download all" button in the batch state, bound to the samedownloadModestate.DownloadModeSelector'sonChangeprop is made optional, since the batch usage has no format selection to reset.Demonstration
Notes
pnpm checkpasses (0 errors). No Rust files touched.