fix(omnibox): restore download mode selector for batch downloads (regression from #197) - #283
Open
Crayz129 wants to merge 1 commit into
Open
Conversation
PR tonhowtf#182 added a DownloadModeSelector above "Download all" in the batch state, so users could force "Audio only" (or "No sound") when pasting multiple URLs. It was reverted unintentionally by tonhowtf#197: that branch was cut from main before tonhowtf#182 landed and its squash merge rewrote src/routes/+page.svelte wholesale, dropping the batch-options block. Re-apply the removed markup and the .batch-options style. Nothing else is needed: handleBatchDownload still forwards downloadMode to the backend, and DownloadModeSelector's onChange prop is still optional. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#182 added the
DownloadModeSelectorabove "Download all" in the batch state, so pasting multiple URLs let you force Audio only / No sound (notably formusic.youtube.comlinks, detected as regular YouTube videos). It's gone again as of 0.8.5.It was not reverted on purpose — it was lost in a merge race:
e8cbf1b9)9a6abc8e). Its squash merge touched 71 files and rewrotesrc/routes/+page.sveltewholesale, dropping thebatch-optionsblock.git log -S"batch-options" -- src/routes/+page.sveltereturns exactly two commits:e8cbf1b9(added) and9a6abc8e(removed). No revert, no discussion.Fix
Re-apply the removed markup and the
.batch-optionsstyle. That's all that's needed — the rest of #182 survived:handleBatchDownloadstill forwardsdownloadModeto the backendDownloadModeSelector'sonChangeprop is still optionalNotes
pnpm checkpasses: 0 errors (107 pre-existing warnings, none new).🤖 Generated with Claude Code