Fix Issue #104 : change link of Topcoder Logo#92
Open
nahidshahin wants to merge 2 commits intotopcoder-archive:developfrom
Open
Fix Issue #104 : change link of Topcoder Logo#92nahidshahin wants to merge 2 commits intotopcoder-archive:developfrom
nahidshahin wants to merge 2 commits intotopcoder-archive:developfrom
Conversation
luizrrodrigues
changed the title
luizrrodrigues
requested changes
Jan 14, 2020
Collaborator
luizrrodrigues
left a comment
luizrrodrigues
left a comment
There was a problem hiding this comment.
Please don't hardcoded the URL, put this inside config file.
Use URL.BASE to non logged user and add a new config to logged user.
You able to see the config files in community-app/config
src/components/TopNav/MobileNav.js
Outdated
| </button> | ||
| </div> | ||
| <a href='/'> | ||
| <a href={loggedIn ? '/my-dashboard' : '/'}> |
Collaborator
There was a problem hiding this comment.
Please don't hardcoded the URL, put this inside config file.
Use URL.BASE to non logged user and add a new config to logged user.
src/components/TopNav/PrimaryNav.js
Outdated
| className={cn(styles.tcLogo, collapsed && styles.tcLogoPush)} | ||
| onClick={onClickLogo} | ||
| href='/' | ||
| href={loggedIn ? '/my-dashboard' : '/'} |
Collaborator
There was a problem hiding this comment.
Please don't hardcoded the URL, put this inside config file.
Use URL.BASE to non logged user and add a new config to logged user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.