Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| .filter(set => set.type === 'PLACEMENT') | ||
| .flatMap(item => item.prizes); | ||
| const prizeTotal = _.sum(placementPrizes.map(prize => prize.value)); | ||
| const prizeType = placementPrizes.length > 0 ? placementPrizes[0].type : null; |
There was a problem hiding this comment.
[❗❗ correctness]
The logic assumes that all prizes in placementPrizes have the same type. If there is a mix of prize types, this could lead to incorrect behavior. Consider verifying that all prize types are consistent or handling mixed types appropriately.
| const prizeTotal = _.sum(placementPrizes.map(prize => prize.value)); | ||
| const prizeType = placementPrizes.length > 0 ? placementPrizes[0].type : null; | ||
| const isPointBasedPrize = prizeType === 'POINT'; | ||
| const prizeSymbol = isPointBasedPrize ? '' : '$'; |
There was a problem hiding this comment.
[❗❗ correctness]
The variable prizeSymbol is determined based on the first prize's type. If placementPrizes contains a mix of types, this could result in an incorrect symbol being displayed. Ensure that the prize type check is robust against such cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community home opportunities feed shows point based challenges with $ symbol