HOTFIX - Update token retrieval to use tcjwt cookie directly#7184
Merged
HOTFIX - Update token retrieval to use tcjwt cookie directly#7184
Conversation
| const authToken = cookies.tcjwt || cookies.tcJwt; | ||
| let tokenV2 = authToken; | ||
| let tokenV3 = authToken; | ||
| let tokenV2 = cookies.tcjwt; |
There was a problem hiding this comment.
[❗❗ correctness]
The change from authToken to cookies.tcjwt for tokenV2 and tokenV3 assumes that cookies.tcjwt is always the correct token to use. If cookies.tcJwt is still valid in some environments, this change might break functionality. Consider verifying that cookies.tcjwt is the correct and only source for both tokens in all environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.