Simplify auth token retrieval in getAuthTokens#7185
Merged
Conversation
Removed support for historical cookie names for auth tokens.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const cookies = req.cookies || {}; | ||
| // Support both historical cookie names used across environments. | ||
| const authToken = cookies.tcjwt || cookies.tcJwt; | ||
| let tokenV2 = cookies.tcjwt; |
There was a problem hiding this comment.
[❗❗ correctness]
The removal of support for the historical cookie name tcJwt is fine if you are certain that all environments and clients have transitioned to using tcjwt. Ensure that there are no legacy systems relying on the old cookie name, as this could lead to authentication issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed support for historical cookie names for auth tokens.