Skip to content

Update terms.js #7189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkartunov merged 1 commit into from
Feb 26, 2026
+7 −0
Merged

Update terms.js #7189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/shared/actions/terms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ const { getService } = services.terms;
* @return {Promise}
*/
function getTermsDone(entity, tokens, mockAgreed) {
if (!tokens || !tokens.tokenV3) {
Copy link

@github-actions github-actions bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
The check for !tokens || !tokens.tokenV3 is a good safeguard, but consider logging this as an error instead of a warning if tokenV3 is expected to be always present. This could help in identifying potential issues in the token generation or passing process.

// eslint-disable-next-line no-console
console.warn(
"getTermsDone called without a valid tokenV3, skipping API call",
);
return Promise.resolve({ entity, terms: [] });
}
const service = getService(tokens.tokenV3);
let termsPromise;

Expand Down
Loading