This repository was archived by the owner on Jan 17, 2025. It is now read-only.
Feature/discern server error #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method `perform_request` now gets passed the whole response in order to check the status code. When the code is 200, the `yield.tap` block is ended. When the code is in the 500 range, an ApiServerError is raised. In all other cases, the original InvalidApiRequest is raised.
When running tests, the API appears to return status code 200 even when triggering an error. To account for this behaviour, I've added checks for both https status codes and api error codes.
|
hey @Marthyn would you be interested in adding specs for this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.