fix: resolve std::optional vs c10::optional namespace conflict #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GCC (8.5.0/10.3.0) pulls in
<optional>via<algorithm>, exposingstd::optionalandstd::nullopt.torch-points-kernelsalso includes PyTorch headers, which exposec10::optionalandc10::nullopt.Because
neighbors.hhadusing namespace std;, both namespaces leaked, causing ambiguity errors.Root Cause
cpu/include/neighbors.husedusing namespace std;.<algorithm>transitively includes<optional>.std::optionalandc10::optionalbecome visible, and this leads to ambiguous references.Fix
using namespace std;fromneighbors.h.vector<>tostd::vector<>in header declarations.neighbors.cpp, add targeted imports:using std::vector;using std::pair;using std::max;knn.cppto usestd::vector<>explicitly.Verification
Build succeeds on: