Skip to content

Conversation

@engineervix
Copy link
Member

@engineervix engineervix commented Dec 8, 2025

Link to Ticket

When applied this MR will

  • Upgrade Wagtail to v7.2
  • Upgrade Node.js to v24
  • Upgrade several outdated python and Node.js dependencies

Important

  • Before it's deployed run poetry update modelsearch to be sure we pick up the latest modelsearch package

How to Test

Please see the relevant spreadsheet

Screenshots

Expand to see more image

Wagtail 7.2 release notes

Add a link to the commit or file for each consideration if you made any code changes.

Code reviewing a consideration.

Use the tick box to indicate a consideration has been code reviewed as OK

Upgrade considerations - changes affecting all projects

Upgrade considerations - deprecation of old functionality

Upgrade considerations - changes to undocumented internals

All versions extras

Identified by the support team as additional considerations to be checked for all Wagtail upgrades

  • Node version should be >=20: Is there a node upgrade to be combined with this? Raise as a follow up action if a node upgrade is required
  • Dockerfile images should be at least python 3.13 and the OS should be pinned. Is there a python docker image upgrade to be combined with this? Raise as a follow up action if a Docker image upgrade is required
  • TBX forms should be updated to at least version if it's used.
  • Django has been updated to the latest 4.2 or 5.2 patch version.
  • If an upgrading.md file exists, update it with the latest information for any future upgrade checks.
  • Overridden admin templates have been updated, if required, to match the latest Wagtail version.
  • Are any wagtail packages using our forked version tags?
  • Run trivy to check for security patches that poetry may not bump.
  • CHANGELOG updated or created.

Additional Considerations

Any other considerations you've made and/or considered.

  • Before it's deployed run poetry update modelsearch to be sure we pick up the latest modelsearch package

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.

  • If your pull request is for a specific ticket, link to it in the description.

  • Stay on point and keep it small so the merge request can be easily reviewed.

  • Tests and linting passes.

  • Added

  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Performance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

Webpack 5 introduced a built-in output.clean option that provides
similar functionality for cleaning the output directory before each build.
…ylelint issues

Relative path issues:

- Change @use 'config' to @use '../config' in base/ and components/
- Change @use 'config' to @use '../../config' in components/navigation/

Resolves sass-loader module resolution error during build

Stylelint issues:

1. **Remove needless stylelint-disable comments** in _grid.scss and _pagination.scss that are no longer needed
2. **Fix @if null check** in _mixins.scss - change from `$variable == null` to `not $variable` (SCSS preferred syntax)
3. **Add interpolation for CSS custom properties** in _variables.scss - wrap all SCSS variables used inside `color.adjust()` with `#{}`
4. Update lint:css script in package.json -- Stylelint should only lint SCSS/CSS files
@engineervix engineervix changed the title Wagtail 7.2 Upgrade Platform Upgrade -- Wagtail 7.2, Node 24 Dec 9, 2025
@engineervix engineervix marked this pull request as ready for review December 9, 2025 15:24
Copy link
Collaborator

@nickmoreton nickmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @engineervix You code changes all look good and the UI looks correct locally.

Can you please update the upgrading.md file, there's a couple of Wagtail 7.1 references to bump to 7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants