-
Notifications
You must be signed in to change notification settings - Fork 4
Platform Upgrade -- Wagtail 7.2, Node 24 #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
engineervix
wants to merge
59
commits into
main
Choose a base branch
from
support/TWE-676-wagtail72
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r 4.15.2 -> 5.2.2
…4 -> 8.2.0 sass-loader 8.0.2 -> 16.0.6
Webpack 5 introduced a built-in output.clean option that provides similar functionality for cleaning the output directory before each build.
…ylelint issues Relative path issues: - Change @use 'config' to @use '../config' in base/ and components/ - Change @use 'config' to @use '../../config' in components/navigation/ Resolves sass-loader module resolution error during build Stylelint issues: 1. **Remove needless stylelint-disable comments** in _grid.scss and _pagination.scss that are no longer needed 2. **Fix @if null check** in _mixins.scss - change from `$variable == null` to `not $variable` (SCSS preferred syntax) 3. **Add interpolation for CSS custom properties** in _variables.scss - wrap all SCSS variables used inside `color.adjust()` with `#{}` 4. Update lint:css script in package.json -- Stylelint should only lint SCSS/CSS files
…0.13.1 -> 0.16.0), boto3 (1.40.18 -> 1.42.5)
nickmoreton
approved these changes
Dec 10, 2025
Collaborator
nickmoreton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @engineervix You code changes all look good and the UI looks correct locally.
Can you please update the upgrading.md file, there's a couple of Wagtail 7.1 references to bump to 7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Ticket
When applied this MR will
Important
poetry update modelsearchto be sure we pick up the latest modelsearch packageHow to Test
Please see the relevant spreadsheet
Screenshots
Expand to see more
Wagtail 7.2 release notes
Add a link to the commit or file for each consideration if you made any code changes.
Code reviewing a consideration.
Use the tick box to indicate a consideration has been code reviewed as OK
Upgrade considerations - changes affecting all projects
Upgrade considerations - deprecation of old functionality
Upgrade considerations - changes to undocumented internals
All versions extras
Identified by the support team as additional considerations to be checked for all Wagtail upgrades
Additional Considerations
Any other considerations you've made and/or considered.
poetry update modelsearchto be sure we pick up the latest modelsearch packageMR Checklist
Add a description of your pull request and instructions for the reviewer to verify your work.
If your pull request is for a specific ticket, link to it in the description.
Stay on point and keep it small so the merge request can be easily reviewed.
Tests and linting passes.
Added
Not required
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library