Add option to close banner #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecelano
requested changes
Sep 23, 2024
Member
josecelano
left a comment
josecelano
left a comment
There was a problem hiding this comment.
HI @mario-nt
I don't know if that was the intended behavior but the text "Read our Terms" is aligned to the right next to the close X.
Contributor
Author
|
@josecelano With my screen resolution (2560x1600) and scale set to 100% it looks like this (which is the intended behaviour):
But if I change the resolution or zoom in it aligns with the text, I will take another look. |
josecelano
requested changes
Sep 30, 2024
Contributor
Author
|
@josecelano Hi!, I didn't notice that the layout of the text was changed when I added the x button to close the banner, I will fix that too. |
mario-nt
force-pushed
the
add-option-to-close-legal-announcement
branch
from
c812998 to
ed056b8
Compare
mario-nt
force-pushed
the
add-option-to-close-legal-announcement
branch
from
ed056b8 to
f64b209
Compare
mario-nt
force-pushed
the
add-option-to-close-legal-announcement
branch
from
f64b209 to
37d1466
Compare
Member
|
ACK 37d1466 |
josecelano
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Banner could use a button to allow the user to close it.