Skip to content

Conversation

JeongHwan-dev
Copy link
Contributor

@JeongHwan-dev JeongHwan-dev commented Jun 18, 2025

📝 Key Changes

Fix missing imports (NumberParam and useCallback) in the useCardIdQueryParam example within the use-page-state-coupling documentation.

The code example was referencing both NumberParam type and useCallback hook but missing the necessary import statements, which would cause compilation errors for developers following the example.

🖼️ Before and After Comparison

Before After

Copy link

vercel bot commented Jun 18, 2025

@JeongHwan-dev is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@milooy milooy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you.
Can you also update in other languages? (en, ja, zh..)

@JeongHwan-dev JeongHwan-dev force-pushed the fix/use-page-state-coupling-example branch from c29cf20 to ca55ec0 Compare July 15, 2025 14:30
@JeongHwan-dev JeongHwan-dev force-pushed the fix/use-page-state-coupling-example branch from ca55ec0 to 54b3973 Compare July 15, 2025 14:30
@JeongHwan-dev
Copy link
Contributor Author

👍 Thank you. Can you also update in other languages? (en, ja, zh..)

@milooy

✅ Done! I've updated the missing imports in all language versions
Thank you👍

@JeongHwan-dev JeongHwan-dev requested a review from milooy July 15, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants