Skip to content

Fix path resolution error for osu!stable on SMB network drives #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
skchqhdpdy wants to merge 4 commits into
base: master
Choose a base branch
from
+8 −1
Draft

Fix path resolution error for osu!stable on SMB network drives #658

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c170329
Resolve SMB path error
skchqhdpdy Jul 9, 2026
bef4144
Resolve SMB path error | Windows Only
skchqhdpdy Jul 9, 2026
3fe9c20
Removed (sep + sep) conditional
skchqhdpdy Jul 10, 2026
d890cf4
lint:fix
skchqhdpdy Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/tosu/src/utils/converters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,17 @@ export const numberFromDecimal = (
* @returns {string} The safely joined path.
*/
export const safeJoin = (...paths: string[]): string => {
// UNC (\\server\share) paths only exist on Windows, so only preserve
// the leading double slash/backslash when running on win32.
const isUnc =
process.platform === 'win32' && /^[/\\]{2}/.test(paths[0] || '');

const cleaned = paths.map((path) => {
if (!path) return '';
return path.trim().replace(/[/\\]+/g, sep);
});

return normalize(join(...cleaned));
const result = normalize(join(...cleaned));

return isUnc ? sep + result : result;
};
Loading