Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sphinx 8.2.0 - drop 3.10 support because Sphinx does #525

Conversation

b-kamphorst
Copy link
Contributor

Closes #523.

@b-kamphorst
Copy link
Contributor Author

This PR fixes some incompatibilities with sphinx 8.2.0. Most notable changes:

  • mock _stringify_annotation now accepts arbitrary *args and **kwargs, which may or may not be desired
  • adds logic for dealing with python_display_short_literal_types (which is the reason the mock broke)

Please take additional care in those changes as they are opinionated / change behaviour. Especially the second one: revisit the tests and ensure that the short syntax produces valid and expected rst.

gaborbernat
gaborbernat previously approved these changes Feb 19, 2025
Signed-off-by: Bernát Gábor <[email protected]>
@gaborbernat gaborbernat changed the title compatibility with sphinx 8.2.0 Support Sphinx 8.2.0 - drop 3.10 support because Sphinx does Feb 19, 2025
@gaborbernat gaborbernat merged commit ca5fcc0 into tox-dev:main Feb 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_stringify_annotation patch breaks in Sphinx==8.2.0
2 participants