Add clj-async-profiler to repl for benchmarking.

toyokumo · Jan 23, 2020 · eed3b8d · eed3b8d
1 parent 895ef01
commit eed3b8d
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 6 deletions.
diff --git a/core/dev/cljstyle/repl.clj b/core/dev/cljstyle/repl.clj
@@ -1,5 +1,6 @@
 (ns cljstyle.repl
   (:require
+    [clj-async-profiler.core :as prof]
     [cljstyle.config :as config]
     [cljstyle.format.core :as fmt]
     [cljstyle.format.zloc :as zl]
@@ -37,3 +38,29 @@
       (as-> x (apply edit-fn x args))
       (node/string)
       (println)))
+
+
+
+;; ## Flame Graphs
+
+(defn massage-stack
+  "Collapse a stack frame in a profiling run."
+  [stack]
+  (-> stack
+      (str/replace #"cljstyle\.task\.process/processing-action/compute-BANG---\d+;(.*;cljstyle\.task\.process/processing-action/compute-BANG---\d+;)?"
+                   "cljstyle.task.process/processing-action/compute! ...;")
+      ,,,))
+
+
+(comment
+  ;; For example:
+  (prof/profile
+    {:event :cpu
+     :transform massage-stack}
+    (try
+      (task/check-sources  ["../.."])
+      (catch Exception _
+        nil)))
+
+  ;; - Should also support `:alloc` profiling
+  ,,,)
diff --git a/core/project.clj b/core/project.clj
@@ -22,5 +22,7 @@
   {:repl
    {:source-paths ["dev"]
     :repl-options {:init-ns cljstyle.repl}
+    :jvm-opts ["-XX:+UnlockDiagnosticVMOptions" "-XX:+DebugNonSafepoints"]
     :dependencies
-    [[org.clojure/tools.namespace "0.3.1"]]}})
+    [[com.clojure-goes-fast/clj-async-profiler "0.4.0"]
+     [org.clojure/tools.namespace "0.3.1"]]}})
diff --git a/core/src/cljstyle/task/process.clj b/core/src/cljstyle/task/process.clj
@@ -72,7 +72,8 @@
             (send results report-result! result)))
 
         compute!
-        (bound-fn []
+        (bound-fn compute!
+          []
           (cond
             (config/ignored? config file)
             (report!
@@ -92,8 +93,10 @@
             (config/directory? file)
             (try
               (let [config' (config/merge-settings config (config/dir-config file))
-                    file->task #(processing-action process! results config' root %)
-                    subtasks (mapv file->task (.listFiles file))]
+                    subtasks (mapv (fn file-task
+                                     [child]
+                                     (processing-action process! results config' root child))
+                                   (.listFiles file))]
                 (ForkJoinTask/invokeAll ^java.util.Collection subtasks))
               (catch Exception ex
                 (report!

diff --git a/core/test/cljstyle/format/type_test.clj b/core/test/cljstyle/format/type_test.clj
@@ -91,8 +91,15 @@
 
   ;; a method comment
   (frobble
-    [bar x y]))")))
-    ,,,))
+    [bar x y]))"))))
+  (testing "nesting"
+    (is (= "(do
+  (defprotocol Foo
+    \"doc string goes here\"
+
+    (abc [foo])))"
+           (reformat-string "(do\n(defprotocol Foo \"doc string goes here\"
+  (abc [foo])))")))))
 
 
 (deftest type-definitions