Fix -E parameter conflict with AAD authentication #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no username is passed to the sqlserver connection URL, the adapter adds the -E parameter to the sqlcmd command. However, when using ActiveDirectoryDefault in the --authentication-method parameter, it doesn't work because the go-sqlcmd program will choose integrated authentication instead of AAD authentication. Integrated authentication is chosen in go-sqlcmd either because the -E parameter is provided or because the username is empty and the authentication method is not specified. This commit prevents the -E parameter from being passed if the authentication method parameter is provided, ensuring that AAD authentication can be used properly.
|
Can confirm this works and is required to work with AAD authentication |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no username is passed to the sqlserver connection URL, the adapter adds the -E parameter to the sqlcmd command. However, when using ActiveDirectoryDefault in the --authentication-method parameter, it doesn't work because the go-sqlcmd program will choose integrated authentication instead of AAD authentication.
Integrated authentication is chosen in go-sqlcmd either because the -E parameter is provided or because the username is empty and the authentication method is not specified.
This commit prevents the -E parameter from being passed if the authentication method parameter is provided, ensuring that AAD authentication can be used properly.