refactor: Button に文字列以外も入れられるようにする #149
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(import 順が変わってるのは Prettier がやりました) |
|
#80 でも新たにボタンを使っているので、それが |
|
#150 ともコンフリクト起きそうな気がするし、立ってるプルリクが少ないタイミングでガッとマージまでしたい気持ち |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #132
各種ボタンのコンポーネント中身の指定の際、
textを props で受け取る代わりに slot を用いるようにしました。中身に文字列だけでなくアイコンなど好きな要素を含められるようになり、汎用性が向上します。