✨ リクエストレート調査用のミドルウェア #2643
Draft
✨ リクエストレート調査用のミドルウェア #2643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a new middleware for logging request rates without enforcing rate limiting, and it leverages a custom in-memory queue to calculate the request rate across the application.
- Added RateLimiterWithLogging middleware to log high request rates.
- Updated router/v3/router.go to integrate the new middleware on the API group.
- Implemented an in-memory access log for rate tracking in router/middlewares/rate_limit.go.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| router/v3/router.go | Integrated new RateLimiterWithLogging middleware into API routes. |
| router/middlewares/rate_limit.go | Added middleware implementation for logging request rates. |
Takeno-hito
requested changes
May 7, 2025
| } | ||
|
|
||
| // RateLimiterWithLogging リクエストレートを記録するミドルウェア (レートが閾値を上回った場合にログを残す) | ||
| func RateLimiterWithLogging(rate rate.Limit, burst int, logger *zap.Logger) echo.MiddlewareFunc { |
There was a problem hiding this comment.
これ、レートリミットをしてそうに見えちゃうので（実際はしてないので混乱の元になる）命名をちょっと練ってほしいです！
|
ramdos0207
reviewed
May 7, 2025
ramdos0207
reviewed
May 7, 2025
| mutex.Lock() | ||
| l := accessLogs.Get(ip) | ||
| l.Add(ok) | ||
| if !ok { |
There was a problem hiding this comment.
逐一ログ出力するとうるさそうなので、ログ出したという事実も手元に持っておいてアクセスログがクリアされるまでは再度ログを出さない、みたいなことをするのもアリかも？（必須ではない）
|
レートはアクセスログから統計取ってくるのが良い気がするので一旦draftにします 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ユーザー数 * 12 * sizeof(int)バイトの領域を確保するようになっています. (24KiBくらい?)