You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
checking new windows before 127 (to validate the method) http://uaf-10.t2.ucsd.edu/~legianni/plots_newWindows_0 - (this is also an errata courage wrt to what was shown in the previous internal meeting) - not fully consistent especially in the detached iterations
Thank you for the MTV plots.
We have a pretty large drop in the 0.4 - 0.8 GeV range.
It would be good to get a variant of MTV plots with efficiency plots selected to be below 0.9 GeV to understand the situation better.
Is "original-127" using the old windows from Mario, or is it rederived?
It would be good to compare cases based on the same machinery to decouple the changes in the parameterization/fitting strategy of the windows.
Do you know roughly how the windows change especially in lower pt bins e.g. in the initialStep iteration?
Naively, the dphi/dq windows should not really change, and the chi2 would change. Is that the case?
From the dist plots it looks like the losses are mainly in 0.5 < |eta| < 1.5, but are still significant in the barrel as well. There is something interesting in one bin near eta of 2.5; perhaps some feature in the window selection in the edge of the acceptance?
This is no longer compatible with master (after the update of the material derivation). We should remember before integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
Fixes to propagation to R error propagation and to application of material effects (the latter from PR #106)
Note about math derivation:
https://www.overleaf.com/read/rkwnmmgpjzkc
PR validation:
ttbar: http://uaf-10.t2.ucsd.edu/~cerati/pr127_mod/
ttbar (using mkFit for low pt iterations): http://uaf-10.t2.ucsd.edu/~cerati/pr127_lowpt_mod/
mu pt<1 using mkFit only for LowPtQuadStep: http://uaf-10.t2.ucsd.edu/~cerati/pr127_mu_lqonly_mod/
The configuration named
modis the same as this PR but with the following lines commented out: https://github.com/cerati/cmssw/blob/fixes-material-p2r-master/RecoTracker/MkFitCore/src/PropagationMPlex.icc#L171-L175It looks like
modgives the best results, so somehow the lines above are problematic for some reason.