Remove additional modules from trackingNtuple sequence, to avoid crash#173
Open
Remove additional modules from trackingNtuple sequence, to avoid crash#173
Conversation
|
perhaps make this upstream for both master and 16.0.X |
slava77
reviewed
Feb 6, 2026
Comment on lines
35
to
39
| process.trackingNtupleSequence = process.hltMultiTrackValidation.copy() | ||
| process.trackingNtupleSequence.insert(0,process.trackingParticlesIntime+process.simHitTPAssocProducer) | ||
| process.trackingNtupleSequence.remove(process.hltPixelLessTracks) | ||
| process.trackingNtupleSequence.remove(process.hltWithPixelTracks) | ||
| process.trackingNtupleSequence.remove(process.hltTrackValidator) |
There was a problem hiding this comment.
Suggested change
| process.trackingNtupleSequence = process.hltMultiTrackValidation.copy() | |
| process.trackingNtupleSequence.insert(0,process.trackingParticlesIntime+process.simHitTPAssocProducer) | |
| process.trackingNtupleSequence.remove(process.hltPixelLessTracks) | |
| process.trackingNtupleSequence.remove(process.hltWithPixelTracks) | |
| process.trackingNtupleSequence.remove(process.hltTrackValidator) | |
| process.trackingNtupleSequence = cms.Sequence(process.hltMultiTrackValidationTask) | |
| process.trackingNtupleSequence.insert(0,process.trackingParticlesIntime+process.simHitTPAssocProducer) |
seems like a more maintainable solution
There was a problem hiding this comment.
the "suggestion" indentation seems off; L36 should be unchanged
mmasciov
force-pushed
the
fixTrackingNtuple
branch
from
a847f36 to
0533220
Compare
…flow for phase-2 HLT menu with tracking ntuple
mmasciov
force-pushed
the
fixTrackingNtuple
branch
from
0533220 to
749b294
Compare
slava77
reviewed
Feb 13, 2026
Comment on lines
+1996
to
+1999
| upgradeWFs['HLTTrackingNtuple75e33'].step2 = { | ||
| '-s':'DIGI:pdigi_valid,DIGI2RAW,L1TrackTrigger,L1,L1P2GT,HLT:75e33,VALIDATION:@hltValidation', | ||
| '--datatier':'GEN-SIM-DIGI-RAW,DQMIO', | ||
| '--eventcontent':'FEVTDEBUGHLT,DQMIO', |
There was a problem hiding this comment.
can you copy this from a reference workflow?
Did you try adding elif 'HARVEST' in step and self.step3 = None: in UpgradeWorkflow_HLT75e33Timing to bypass this step?
That way the full .7502 could fit into 2-3 lines, a deepcopy from a reference and .step3=None and `.step2['--customise'] += ",Validation/RecoTrack/cust..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
Bug-fix, to avoid that tracking ntuple for phase-2 HLT crashes, due to the missed removal of two additional modules.
PR validation:
Tested in 16_0_0_pre4, where the issue shows up.
FYI @bdanzi