Draft
Conversation
leonardogiannini
force-pushed
the
material-calibration
branch
from
0f34d1a to
e60c7e4
Compare
Author
|
note: validation looks correct timing test look inconsistent, when checking module by module, so rerun a few vs before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for the validation you can check this MTV comparison - mkFit vs CKF:
http://uaf-10.t2.ucsd.edu/~legianni/mkFitFit-debug-2026/PSMODULES/plots_finalCheck/
mkFit before and after are compared here:
http://uaf-10.t2.ucsd.edu/~legianni/mkFitFit-debug-2026/PSMODULES/TT_testCalib7smooth2
more explanations in the gdoc
--
the extra commits are the ones in previous PRs since I was working in CMSSW_16_0_0_pre3, but I need to remove them