feat(episode): include guest stars in episode credits - #2567
Conversation
|
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Jun 10, 2026 2:43p.m. | Review ↗ | |
| Code coverage | Jun 10, 2026 2:43p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (Overall) |
|---|---|
| Aggregate | 67% [▲ up 0.1% from main] |
| Javascript | 67% [▲ up 0.1% from main] |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
1689ba2 to
4d76f47
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for displaying guest stars and supporting cast in episode summaries and the cast drawer. It updates the API request to fetch guest stars, maps them to the media crew, and refactors the cast drawer to group cast members into 'Main Cast' and 'Supporting Cast' using a new CreditGroupHeader component. Feedback points out a type assertion bypass in episodePeopleQuery.ts where 'images,guest_stars' as 'images' is used, and suggests updating the underlying API client type definitions instead to maintain type safety.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| }, | ||
| query: { | ||
| extended: 'images', | ||
| extended: 'images,guest_stars' as 'images', |
There was a problem hiding this comment.
The type assertion 'images,guest_stars' as 'images' bypasses TypeScript's type checking. Avoid using broad type casts (such as as any or incorrect literal assertions) to work around type limitations in production code, as this reduces type safety and maintainability. Instead, consider updating the underlying API client type definitions to properly support the extended parameters.
References
- Avoid using broad type casts like
as neverto bypass type checking. Instead, use type narrowing to handle specific types safely. This improves type safety and maintainability, especially when dealing with API response types.
Pull request was converted to draft
b9271a4 to
41dd680
Compare
|
Is there any update on when this will be merged? This is a feature I really want added back. |
d6ed106 to
637bdc2
Compare

Summary
extended=images,guest_starsand mapguest_stars.Cast.Main CastandSupporting Cast.Cast(eg: Black Mirror)Note: API improvements on sorting cast and guests still in progress, it will feel even better when done.
Look and Feel
Show
Movie
Black Mirror == show with only "guest" stars