Skip to content

feat(episode): include guest stars in episode credits - #2567

Draft
kevincador wants to merge 1 commit into
mainfrom
feat/episode-guest-stars
Draft

feat(episode): include guest stars in episode credits#2567
kevincador wants to merge 1 commit into
mainfrom
feat/episode-guest-stars

Conversation

@kevincador

Copy link
Copy Markdown
Contributor

Summary

  • Fetch episode people with extended=images,guest_stars and map guest_stars.
  • Include episode guest stars in the Actors row by appending them after main cast.
  • Keep show and movie people behavior unchanged: no guest-star fetch for shows or movies, and their Actors rows use main cast only.
  • Group People drawer cast results with section headers:
    • Shows and movies use Cast.
    • Episodes with main cast use Main Cast and Supporting Cast.
    • Episodes with only supporting cast use Cast (eg: Black Mirror)
    • Empty groups are hidden.
  • Keep search across main cast, supporting cast, and crew while preserving visible group headers.
  • Hide episode-count tags for episode credits; show counts remain visible for show credits only.

Note: API improvements on sorting cast and guests still in progress, it will feel even better when done.

Look and Feel

Show

Screenshot 2026-06-10 at 10 14 41 Screenshot 2026-06-10 at 10 15 02

Movie

Screenshot 2026-06-10 at 10 14 32

Black Mirror == show with only "guest" stars

Screenshot 2026-06-10 at 10 15 24 Screenshot 2026-06-10 at 10 15 36

@trakt-bot
trakt-bot Bot enabled auto-merge (rebase) June 10, 2026 08:21
@deepsource-io

deepsource-io Bot commented Jun 10, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 6a83d90...4d76f47 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Jun 10, 2026 2:43p.m. Review ↗
Code coverage Jun 10, 2026 2:43p.m. Review ↗

Code Coverage Summary

Language Line Coverage (Overall)
Aggregate
67%
[▲ up 0.1% from main]
Javascript
67%
[▲ up 0.1% from main]

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the summary. You can try again by commenting /gemini summary.

@seferturan
seferturan force-pushed the feat/episode-guest-stars branch from 1689ba2 to 4d76f47 Compare June 10, 2026 14:43
@seferturan

Copy link
Copy Markdown
Contributor

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for displaying guest stars and supporting cast in episode summaries and the cast drawer. It updates the API request to fetch guest stars, maps them to the media crew, and refactors the cast drawer to group cast members into 'Main Cast' and 'Supporting Cast' using a new CreditGroupHeader component. Feedback points out a type assertion bypass in episodePeopleQuery.ts where 'images,guest_stars' as 'images' is used, and suggests updating the underlying API client type definitions instead to maintain type safety.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

},
query: {
extended: 'images',
extended: 'images,guest_stars' as 'images',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The type assertion 'images,guest_stars' as 'images' bypasses TypeScript's type checking. Avoid using broad type casts (such as as any or incorrect literal assertions) to work around type limitations in production code, as this reduces type safety and maintainability. Instead, consider updating the underlying API client type definitions to properly support the extended parameters.

References
  1. Avoid using broad type casts like as never to bypass type checking. Instead, use type narrowing to handle specific types safely. This improves type safety and maintainability, especially when dealing with API response types.

@vladjerca vladjerca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as Diego Luna is the only main star of Andor I disagree with this feature.

Image

@kevincador
kevincador marked this pull request as draft June 15, 2026 16:56
auto-merge was automatically disabled June 15, 2026 16:56

Pull request was converted to draft

@kevincador kevincador self-assigned this Jun 15, 2026
@vladjerca
vladjerca force-pushed the main branch 2 times, most recently from b9271a4 to 41dd680 Compare June 29, 2026 19:29
@addisonxx

Copy link
Copy Markdown

Is there any update on when this will be merged? This is a feature I really want added back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants