Media: use new translation language query param - #3084
Draft
rectifyer wants to merge 1 commit into
Draft
Conversation
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Aug 4, 2026 11:00p.m. | Review ↗ | |
| Code coverage | Aug 4, 2026 11:30p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@trakt/apito 0.6.0 and migrates the translations calls to the new contract shape, where thelanguagefilter is an optional query param instead of a path segment (trakt/trakt-api#901, refs trakt/trakt-api#869). The client now requests/translations?language=xxinstead of/translations/xx.Changes
@trakt/apipin bumped from 0.5.4 to 0.6.0 inprojects/client/package.json.movieIntlQuery,showIntlQuery, andepisodeIntlQuerypasslanguageviaqueryinstead ofparams./translations/{lang}mocks (movie en/nl/pt, show en/nl/ja, episode en/nl) are collapsed into single/translationshandlers that serve the same mock data keyed off thelanguagequery param, since the old path-based handlers would no longer match the new request URLs.Dependencies
Draft until the upstream pieces land, in order:
?language=on the translations endpoints.@trakt/api0.6.0 is published (tagv0.6.0).deno.lockwith an install (the 0.6.0 pin cannot resolve before publish) and mark ready for review.Merging early would fail install in CI on the unresolvable 0.6.0 pin, and running ahead of the Rails deploy would return unfiltered translations because the query param is ignored.