List: link to lists from the manage lists drawer - #3164
Conversation
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
|
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Aug 20, 2026 8:18p.m. | Review ↗ | |
| Code coverage | Aug 20, 2026 8:18p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (Overall) |
|---|---|
| Aggregate | 69.3% |
| Javascript | 69.3% |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
ElMagnea
left a comment
There was a problem hiding this comment.
I think we're turning this into an Excel sheet. I'm thinking of different ways of solving this. I totally understand the need here, I just want it to look less visually heavy.
What if we split it up a bit? Default is as it is nowadays, just simply add/remove. And then a toggle to switch to a mode where you can add, view, edit, and delete lists? Screen.Recording.2026-08-21.at.13.36.35.mov@ElMagnea @rectifyer thoughts? |
|
@seferturan I'm down with it. I think it keeps things neater but also offers additional options |
|
Outside opinion as issue author: When you want to inspect a list from the Manage Lists view, now you have to switch to the other tab, find the list again, which you just saw right there in the first tab but is now in a different position without the "linked" sorting (which wouldn't make sense here) and without the Watchlist entry (it can't have edit and delete, so either it's not included at all and there is no link to it, or its item has to be different from the others), and click it there, then return to the first tab to keep editing. The whole point of the issue was that you shouldn't have to navigate to another view and re-find the list there to view a list that you just saw right there in the drawer. It feels odd not to be able to just get there from within that same view. Also, I get that once there was this second tab you'd want to fill it with more than just a list of list names again, only this time with links, but you're still on a media detail page or a search page or similar. It doesn't feel like the right place for either editing or removing a list, and you'd just have to follow the link to the list to get those options anyway. Some alternative ideas:
|
Summary
Adds direct navigation to lists from the Manage lists drawer (closes #3105). Each row is now a split control: the main area still toggles membership, and a new divided caret segment on the trailing edge links to the list page, with a "View list" tooltip on hover. The watchlist row gets the same treatment, linking to
/users/me/watchlist.As a follow-up sprinkle, adding or removing an item now flashes the row background using the same effect as list reordering: purple when added, muted red when removed.
Changes
DropdownItemgains anactionsnippet rendered as a divided trailing segment whose pointer/focus events never reach the row, with its own hover, active, and focus-ring styling, plus aflashvariant (data-flash) that overlays the purple/red background animation.ListDropdownItembuilds the list URL fromownerSlug/slugwith a numeric-id fallback, and the drawer's rows read canonical slugs overlaid byuseAllPersonalListsfrom the personal + collaboration list summary queries (the minimal v3 payload carries no slugs).WatchlistButtonforwardsactionandflashto its dropdown-item rendering.ListsDrawerflashes rows off the listed-ids diff (survives the re-sort after toggling) and the watchlist row off the update lifecycle; the row layout switches fromrow-reverseto bookmark-leading with the caret trailing.background-flashkeyframes +--animation-duration-background-flashtoken instyle/animations, auseBackgroundFlashrune hook, andBACKGROUND_FLASH_DURATION;ReorderDrawerconsumes all three instead of its local copies.link_label_view_list,tooltip_view_list,link_label_view_watchlist,tooltip_view_watchlist.Screenshots
View list icon + tooltip
Highlight after adding to a list
What it looked like before
Notes
--transition-increment, which collapses to0msunderprefers-reduced-motion.