Skip to content

List: link to lists from the manage lists drawer - #3164

Open
rectifyer wants to merge 2 commits into
mainfrom
refactor/manage_lists_view
Open

List: link to lists from the manage lists drawer#3164
rectifyer wants to merge 2 commits into
mainfrom
refactor/manage_lists_view

Conversation

@rectifyer

@rectifyer rectifyer commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds direct navigation to lists from the Manage lists drawer (closes #3105). Each row is now a split control: the main area still toggles membership, and a new divided caret segment on the trailing edge links to the list page, with a "View list" tooltip on hover. The watchlist row gets the same treatment, linking to /users/me/watchlist.

As a follow-up sprinkle, adding or removing an item now flashes the row background using the same effect as list reordering: purple when added, muted red when removed.

Changes

  • DropdownItem gains an action snippet rendered as a divided trailing segment whose pointer/focus events never reach the row, with its own hover, active, and focus-ring styling, plus a flash variant (data-flash) that overlays the purple/red background animation.
  • ListDropdownItem builds the list URL from ownerSlug/slug with a numeric-id fallback, and the drawer's rows read canonical slugs overlaid by useAllPersonalLists from the personal + collaboration list summary queries (the minimal v3 payload carries no slugs).
  • WatchlistButton forwards action and flash to its dropdown-item rendering.
  • ListsDrawer flashes rows off the listed-ids diff (survives the re-sort after toggling) and the watchlist row off the update lifecycle; the row layout switches from row-reverse to bookmark-leading with the caret trailing.
  • The reorder flash is now shared: background-flash keyframes + --animation-duration-background-flash token in style/animations, a useBackgroundFlash rune hook, and BACKGROUND_FLASH_DURATION; ReorderDrawer consumes all three instead of its local copies.
  • New i18n keys: link_label_view_list, tooltip_view_list, link_label_view_watchlist, tooltip_view_watchlist.

Screenshots

View list icon + tooltip

image

Highlight after adding to a list

Xnapper-2026-08-20-13 20 29

What it looked like before

before

Notes

  • Reduced motion is respected for free: the flash duration token derives from --transition-increment, which collapses to 0ms under prefers-reduced-motion.
  • Cancelling the remove confirmation never flashes, since the listed-ids never change.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@trakt-bot
trakt-bot Bot enabled auto-merge (rebase) August 20, 2026 20:19
@rectifyer rectifyer changed the title feat(list): link to lists from the manage lists drawer List: link to lists from the manage lists drawer Aug 20, 2026
@deepsource-io

deepsource-io Bot commented Aug 20, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 1d441c3...b340ec8 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Aug 20, 2026 8:18p.m. Review ↗
Code coverage Aug 20, 2026 8:18p.m. Review ↗

Code Coverage Summary

Language Line Coverage (Overall)
Aggregate
69.3%
Javascript
69.3%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@ElMagnea ElMagnea left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're turning this into an Excel sheet. I'm thinking of different ways of solving this. I totally understand the need here, I just want it to look less visually heavy.

@seferturan

Copy link
Copy Markdown
Contributor

I think we're turning this into an Excel sheet. I'm thinking of different ways of solving this. I totally understand the need here, I just want it to look less visually heavy.

What if we split it up a bit? Default is as it is nowadays, just simply add/remove. And then a toggle to switch to a mode where you can add, view, edit, and delete lists?
Quick prototype, ignore the ugly design:

Screen.Recording.2026-08-21.at.13.36.35.mov

@ElMagnea @rectifyer thoughts?

@ElMagnea

Copy link
Copy Markdown
Collaborator

@seferturan I'm down with it. I think it keeps things neater but also offers additional options

@janobi

janobi commented Aug 21, 2026

Copy link
Copy Markdown

Outside opinion as issue author:
I kind of get the point about an additional icon column making the drawer feel more crowded, but I don't think it's that bad and the tab switch doesn't really make sense to me. It makes the drawer feel more convoluted than it needs to be and essentially builds a mini version of the list overview page where it doesn't feel like it belongs.

When you want to inspect a list from the Manage Lists view, now you have to switch to the other tab, find the list again, which you just saw right there in the first tab but is now in a different position without the "linked" sorting (which wouldn't make sense here) and without the Watchlist entry (it can't have edit and delete, so either it's not included at all and there is no link to it, or its item has to be different from the others), and click it there, then return to the first tab to keep editing. The whole point of the issue was that you shouldn't have to navigate to another view and re-find the list there to view a list that you just saw right there in the drawer. It feels odd not to be able to just get there from within that same view.

Also, I get that once there was this second tab you'd want to fill it with more than just a list of list names again, only this time with links, but you're still on a media detail page or a search page or similar. It doesn't feel like the right place for either editing or removing a list, and you'd just have to follow the link to the list to get those options anyway.

Some alternative ideas:

  • Maybe just get rid of the bookmark icon and use the background to visualize the active state, so it's back to just one icon per row. The bookmark icon is already associated with the button and tag purely for the watchlist, so using it for normal lists just confuses its meaning anyway.
  • Maybe only add scrollwheel-clicking on the item to open in a new tab, no extra link area needed. Regular clicks can still add/remove as before. Opening the link in a new tab seems more useful than navigating to the list on the same page anyway. Not very discoverable though, and not sure how this could work on mobile.
  • Maybe only show the link per item on hover. Could end up too busy visually, but there already is a the background change on mouseover, so maybe it would just sneak into the same visual change without too much of a fuzz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link to lists in "Manage Lists" drawer

4 participants