@uppy/dashboard: do not allow drag&drop of file preview #5650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff output filesdiff --git a/packages/@uppy/dashboard/lib/components/FilePreview.js b/packages/@uppy/dashboard/lib/components/FilePreview.js
index fd25afe..35cc0d9 100644
--- a/packages/@uppy/dashboard/lib/components/FilePreview.js
+++ b/packages/@uppy/dashboard/lib/components/FilePreview.js
@@ -6,6 +6,7 @@ export default function FilePreview(props) {
} = props;
if (file.preview) {
return h("img", {
+ draggable: false,
className: "uppy-Dashboard-Item-previewImg",
alt: file.name,
src: file.preview, |
github-actions bot
added a commit
that referenced
this pull request
Feb 25, 2025
| Package | Version | Package | Version | | ---------------- | ------- | ---------------- | ------- | | @uppy/companion | 5.5.2 | @uppy/xhr-upload | 4.3.3 | | @uppy/dashboard | 4.3.2 | uppy | 4.13.3 | | @uppy/status-bar | 4.1.2 | | | - @uppy/dashboard: do not allow drag&drop of file preview (Merlijn Vos / #5650) - @uppy/xhr-upload: fix when responseType is set to JSON (Merlijn Vos / #5651) - meta: build(deps): bump akhileshns/heroku-deploy from 3.13.15 to 3.14.15 (dependabot[bot] / #5659) - meta: build(deps): bump docker/build-push-action from 6.13.0 to 6.14.0 (dependabot[bot] / #5660) - @uppy/status-bar: fix aria-hidden warning (Merlijn Vos / #5663) - @uppy/companion: log when tus uploaded size differs (Mikael Finstad / #5647) - @uppy/companion: remove redundant HEAD request for file size (Mikael Finstad / #5648) - meta: build(deps): bump elliptic from 6.6.0 to 6.6.1 (dependabot[bot] / #5649) - examples: build(deps-dev): bump esbuild from 0.21.5 to 0.25.0 (dependabot[bot] / #5643) - meta: build(deps-dev): bump vitest from 1.6.0 to 1.6.1 (dependabot[bot] / #5641) - meta: build(deps): bump docker/setup-qemu-action from 3.3.0 to 3.4.0 (dependabot[bot] / #5640)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5639
Browsers have subtle differences when which makes it hard to detect a duplicate between a generated file preview and the original file so we simply do not allow drag & drop of the generated file preview.