chore(safe): upgrade form-data to 4.0+ to fix CVE-2023-50498 QA-237 - #2
chore(safe): upgrade form-data to 4.0+ to fix CVE-2023-50498 QA-237#2zzzboo wants to merge 1 commit into
Conversation
WalkthroughA new "overrides" section was added to the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
vue/package.json (1)
40-41: Consider adding a Yarn fallback for teams not usingnpm ≥8.
"overrides"is annpm-specific field.
If any consumers of this repo rely on Yarn ≤1 they will ignore it and still get the vulnerable version.
Providing a parallel"resolutions"entry keeps both ecosystems safe.Example:
"overrides": { "form-data": "^4.0.0" + }, + "resolutions": { + "form-data": "^4.0.0" }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
vue/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (1)
vue/package.json (1)
39-42: Add the regenerated lock-file to guarantee the override is applied in CI/CD.
npm overridesonly take effect after a freshnpm install, which rewritespackage-lock.json.
Without committing that updated lock-file the build pipeline (and future developers) may still resolve a vulnerable<4version.Action items
# after running `npm install` locally +git add package-lock.jsonPlease confirm that the updated lock-file now pins
form-datato^4.0.0in the resolved tree.
upgrade form-data to 4.0
Summary by CodeRabbit