Skip to content

chore: upgrade Node.js baseline to 22 (DEV-915) - #35

Draft
chriszhao1988 wants to merge 1 commit into
feature/1.0from
feature/node22-upgrade-DEV-915
Draft

chore: upgrade Node.js baseline to 22 (DEV-915)#35
chriszhao1988 wants to merge 1 commit into
feature/1.0from
feature/node22-upgrade-DEV-915

Conversation

@chriszhao1988

Copy link
Copy Markdown
Collaborator

Summary

  • add explicit Node 22 runtime declarations for local development and package metadata
  • upgrade GitHub test CI from Node 18 to Node 22
  • keep the change surface limited to baseline alignment without touching package dependencies

Validation

  • npm test
  • eslint binary starts successfully under Node 22
  • note: the repo's full lint command does not terminate promptly in this local environment and showed the same behavior before the change

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8a16c5dc-b6c6-428a-8cab-554298c4e59f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/node22-upgrade-DEV-915

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chriszhao1988

Copy link
Copy Markdown
Collaborator Author

Final completion summary for DEV-915:

  • Base branch is feature/1.0 because this repo does not have develop
  • Added .nvmrc with 22.22.0
  • Added top-level engines.node: >=22 <23 and engines.npm: >=10
  • Updated GitHub test CI from Node 18 to Node 22
  • Diff stays limited to baseline-alignment files only

Validation:

  • npm test -> 11 suites passed, 23 tests passed
  • eslint --version -> v7.32.0 under Node 22
  • Full lint command did not terminate promptly in the local environment; no new Node 22-specific lint error was observed before interruption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant