rpassword: Write newlines to sink when read fails #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Oct 13, 2025
src/pam/rpassword.rs
Outdated
Comment on lines
287
to
288
| let rslt = if let Some(hide_input) = HiddenInput::new(true)? { | ||
| match self { |
There was a problem hiding this comment.
This can stay a single match, right? So let ret = match (HiddenInput::new(true)?, self) { ... };
There was a problem hiding this comment.
I don't think so... as I noted in the commit message (expanded upon in the second submission), creating the tuple could cause a move of self, which we need to use later. Here's a silly example.
There was a problem hiding this comment.
Wouldn't &mut *self work in that case?
|
Thanks for the PR! |
Creating the tuple `(HiddenInput::new(true)?, self)` moves `self`, which we still need to use later (to write a newline if the read fails). Signed-off-by: Wesley Hershberger <[email protected]>
Fixes trifectatechfoundation#1171 Signed-off-by: Wesley Hershberger <[email protected]>
MggMuggins
force-pushed
the
fix-timeout-fmt
branch
from
2bc945e to
07cf17f
Compare
|
Here's the rebase delta: MggMuggins/sudo-rs@fix-timeout-fmt-v1...fix-timeout-fmt-v2 |
squell
added
C-pam
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1171
Happy to put together an automated test for this but I thought I'd start with an implementation.