Native input prompt on Android and iOS#7
Open
jaydeepw wants to merge 5 commits intotrigger-corp:masterfrom
Open
Native input prompt on Android and iOS#7jaydeepw wants to merge 5 commits intotrigger-corp:masterfrom
jaydeepw wants to merge 5 commits intotrigger-corp:masterfrom
Conversation
Contributor
|
Hi guys, This looks really promising! If you could document the API for the proposed method in module/docs/index.md we can get this reviewed and hopefully pushed out into release. Thanks! |
Author
|
OK, will do. |
|
@jaydeepw Let's get this going please! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using HTML5 prompt would suffice but we could not find a way to remove the header that says
"Page at example.com/abc says"
from the HTML5 input prompt.
I was not developing on Mac so iOS prompt code is not tested but you will definitely get the idea of what is going on.