perf(webapp): Add index to speedup waitpoint tokens dashboard list query

[ericallam]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: e8a348a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

Adds a Prisma schema change to define an index on the Waitpoint model across environmentId, type, and id in descending order, preceded by a documentation comment. Introduces a corresponding SQL migration that creates the index concurrently on public.Waitpoint with the same column ordering, using CREATE INDEX CONCURRENTLY IF NOT EXISTS. No other models, fields, or exported entities are modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Small scope with two files; straightforward index addition mirrored between Prisma schema and SQL migration. Low logic density and low heterogeneity; primary checks involve column order, sort direction, naming consistency, and concurrent/IF NOT EXISTS usage.

Pre-merge checks (2 passed, 1 inconclusive)

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description Check	❓ Inconclusive	I cannot evaluate the PR description because the current pull request description and the repository's required description template were not provided in the input, so there is no content to compare against the template or required sections. Without that text I cannot determine whether required sections like summary, motivation, testing, and migration notes are present or complete.	Please provide the PR's full description and the repository's description template (or confirm the template headings); ensure the description includes a short summary, motivation, testing performed, migration notes for the new index, and any rollout/rollback or performance considerations, then I will re-check and give a pass/fail assessment.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title concisely and accurately states the primary change — adding an index to improve performance for the waitpoint tokens dashboard query — and matches the schema change and concurrent SQL migration that create the index on Waitpoint(environmentId, type, id). The phrasing is specific to the performance intent and is appropriate for a teammate scanning history.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ea-branch-85

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

internal-packages/database/prisma/migrations/20250912153951_add_waitpoint_dashboard_index/migration.sql (1)

2-2: Optional: validate idx usage with the dashboard query.

If the query filters by environmentId and type and orders by id DESC with LIMIT, this index should be picked. If the query also filters on status or a time window predominantly, consider whether an alternate or partial index would outperform.

Would you like me to draft EXPLAIN variants for the common query shapes you expect?

internal-packages/database/prisma/schema.prisma (2)

1065-1067: Pin the DB index name to avoid drift.

Prisma’s default name matches your SQL migration today, but future renames/truncation could diverge. Add map to lock it to Waitpoint_environmentId_type_id_idx.

-  /// For the waitpoint token dashboard page
-  @@index([environmentId, type, id(sort: Desc)])
+  /// For the waitpoint token dashboard page
+  @@index([environmentId, type, id(sort: Desc)], map: "Waitpoint_environmentId_type_id_idx")

---

1065-1067: Sanity-check the sort key vs. access pattern.

If the dashboard relies on recent items, createdAt DESC is typically more correlated with recency than cuid-based id DESC. If you’re paginating by id cursor specifically, current choice is correct; otherwise consider a createdAt-based index.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2eddda1 and e8a348a.

📒 Files selected for processing (2)

• internal-packages/database/prisma/migrations/20250912153951_add_waitpoint_dashboard_index/migration.sql (1 hunks)
• internal-packages/database/prisma/schema.prisma (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)

• GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
• GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
• GitHub Check: typecheck / typecheck
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (2)

internal-packages/database/prisma/migrations/20250912153951_add_waitpoint_dashboard_index/migration.sql (2)

2-2: Good index choice and concurrent creation.

Name, column order, and DESC on id line up with the stated dashboard query and minimize write blocking via CONCURRENTLY. LGTM.

---

2-2: Confirm non-transactional application of this migration.

CREATE INDEX CONCURRENTLY cannot run inside a transaction. Ensure Prisma applies this migration in a non-transactional mode; otherwise deploys will fail. Please verify on your CI/staging run logs.