service: seperate coordinator and worker service #360
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
| @@ -1,4 +1,5 @@ | |||
| {{- $coordinatorJmx := merge .Values.jmx.coordinator (omit .Values.jmx "coordinator" "worker") -}} | |||
| {{- $svc := .Values.service | default .Values.serviceCoordinator }} | |||
There was a problem hiding this comment.
Should we merge the coordinator service with the "general" service, like we do for JMX above?
There was a problem hiding this comment.
IMHO it's better to keep them separated, or even add a deprecation warning for Values.service.
There was a problem hiding this comment.
I'm ok with keeping them separated, but we should make sure no values are silently ignored. So we should call fail() when using the coordinator or worker services, and there's anything set in the shared service.
parsa97
force-pushed
the
seperate-worker-coordinator-service
branch
from
de9293c to
bafdcf7
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Signed-off-by: Parsa Yousefi <[email protected]>
parsa97
force-pushed
the
seperate-worker-coordinator-service
branch
from
bafdcf7 to
1d8c734
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
Fix issue #269