Skip to content

Add tests for the "ClientSession" class #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add tests for the "ClientSession" class #504

merged 1 commit into from
Jan 10, 2025

Conversation

arturdryomov
Copy link
Member

Description

Tests for the client.ClientSession class, including getters and setters. Relatively simple except the roles property.

Release notes

This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Dec 19, 2024
@arturdryomov arturdryomov requested a review from hashhar December 19, 2024 11:34
@arturdryomov
Copy link
Member Author

👀 @hashhar

@arturdryomov
Copy link
Member Author

@hashhar, hey, can I ask you to take a look at this one and #505? I wanted to continue the work on adding typing annotations and to avoid merge conflicts if possible.

@hashhar hashhar merged commit bf0f8c1 into trinodb:master Jan 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arturdryomov @hashhar