Fix test_segments_cursor #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@damian3031 incorrect. Inline and spooled segments were allowed from the beginning. Linked issue has nothing to do with it |
damian3031
force-pushed
the
damian/fix-test-segment-cursor
branch
from
4a417dd to
a75efd1
Compare
wendigo
approved these changes
Jun 10, 2025
@wendigo I mean that after Increasing inlining allowance in spooling protocol, we are getting some InlineSegments in this particular test, and before we were getting only SpooledSegments. I changed it to make assertions based on segment type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test_segments_cursoris passing on Trino 475, but failing on Trino 476 with error:My understanding is that after this change trinodb/trino#25940, some Segments are Inline, whereas before, all of them were Spooled.
Since InlineSegment doesn't contain
uriandack_uri, I added a check for the existence of these attributes before asserting their types.Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: