Skip to content

Only check access control on underlying MV tables on refresh #25872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codyzwief
Copy link
Contributor

@codyzwief codyzwief commented May 27, 2025

Description

This change only checks access control of queries which support a materialized view when running a refresh. The actual refresh permissions check is unaffected. Before this change, permissions on the underlying MV query were always checked, even on a SELECT. More details can be found in #23747

Additional context and related issues

#23747

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Section
* Only check permissions of underlying MV query on MV refresh. ({issue}`23747`)

@cla-bot cla-bot bot added the cla-signed label May 27, 2025
@codyzwief codyzwief force-pushed the codyzwief/mv-priv-issue-23747 branch 3 times, most recently from ef2179c to 90e4fd7 Compare May 30, 2025 12:52
@codyzwief codyzwief changed the title [DRAFT] [WIP] [DO NOT REVIEW] Only check access control on underlying MV tables on refresh Only check access control on underlying MV tables on refresh May 30, 2025
@codyzwief codyzwief requested review from martint and dain May 30, 2025 19:41
@codyzwief codyzwief marked this pull request as ready for review May 30, 2025 19:41
@codyzwief codyzwief force-pushed the codyzwief/mv-priv-issue-23747 branch 2 times, most recently from 634b409 to 465a21d Compare June 10, 2025 20:41
@codyzwief codyzwief force-pushed the codyzwief/mv-priv-issue-23747 branch from 465a21d to 24727b0 Compare June 16, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant