Update logic to use short-circuit logical operations #25874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
reviewed
Jun 2, 2025
| @@ -63,7 +63,7 @@ public void serialize(LongDecimalWithOverflowAndLongState state, BlockBuilder ou | |||
| // high != 0 (countOffset = 2) | |||
| // overflow == 0 & count == 1 -> bufferLength = 2 | |||
| // overflow != 0 || count != 1 -> bufferLength = 4 | |||
| int bufferLength = countOffset + ((overflow == 0 & count == 1) ? 0 : 2); | |||
There was a problem hiding this comment.
nit: this might by purpouse IRC to avoid branching
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
trino/coreRelease notes
( x ) This is not user-visible or is docs only, and no release notes are required.