Skip to content

Fix preview UI to render long single line SQLs correctly #27328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

Fix preview UI to render long single line SQLs correctly #27328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions core/trino-web-ui/src/main/resources/webapp-preview/src/components/CodeBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,28 @@ export const CodeBlock = (props: ICodeBlockProps) => {
return
}

const lineHeightOption = editor.getOption(monaco.editor.EditorOption.lineHeight)
const lineHeight = typeof lineHeightOption === 'number' ? lineHeightOption : FALLBACK_LINE_HEIGHT_PX
const lineCount = Math.max(code.split(LINE_BREAK_REGEX).length, 1)
const estimatedHeight = lineCount * lineHeight + EDITOR_EXTRA_PADDING
const viewportCap = window.innerHeight * VIEWPORT_HEIGHT_RATIO
const clampedHeight = Math.min(estimatedHeight, viewportCap)
setResolvedHeight(`${Math.round(clampedHeight)}px`)
const estimateHeightFromLines = () => {
const lineHeightOption = editor.getOption(monaco.editor.EditorOption.lineHeight)
const lineHeight = typeof lineHeightOption === 'number' ? lineHeightOption : FALLBACK_LINE_HEIGHT_PX
const lineCount = Math.max(code.split(LINE_BREAK_REGEX).length, 1)
return lineCount * lineHeight + EDITOR_EXTRA_PADDING
}

const updateHeight = (contentHeight?: number) => {
const rawHeight =
typeof contentHeight === 'number' ? contentHeight + EDITOR_EXTRA_PADDING : estimateHeightFromLines()
const viewportCap = window.innerHeight * VIEWPORT_HEIGHT_RATIO
const clampedHeight = Math.min(rawHeight, viewportCap)
setResolvedHeight(`${Math.round(clampedHeight)}px`)
}

updateHeight(editor.getContentHeight())

const disposable = editor.onDidContentSizeChange((event) => {
updateHeight(event.contentHeight)
})

editor.onDidDispose(() => disposable.dispose())
}

const defaultMonacoOptions: MonacoEditor.IStandaloneEditorConstructionOptions = {
Expand Down Expand Up @@ -94,6 +109,7 @@ export const CodeBlock = (props: ICodeBlockProps) => {
border: `1px solid ${theme.palette.mode === 'dark' ? '#3f3f3f' : '#ddd'}`,
borderBottom: noBottomBorder ? 'none' : '',
width: '100%',
height: '100%',
maxHeight: '90vh',
})}
>
Expand Down