Replace s3.exclusive-create config with Delta Lake's one
#27372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
changed the title
s3.exclusive-create config with Delta Lake's one
findepi
force-pushed
the
findepi/delta-s3
branch
2 times, most recently
from
d882882 to
14bde63
Compare
losipiuk
reviewed
Nov 20, 2025
findepi
force-pushed
the
findepi/delta-s3
branch
from
14bde63 to
9ac1938
Compare
findepi
commented
Nov 21, 2025
lib/trino-filesystem-s3/src/test/java/io/trino/filesystem/s3/TestS3FileSystemS3Mock.java
Show resolved
Hide resolved
lib/trino-filesystem-s3/src/test/java/io/trino/filesystem/s3/TestS3FileSystemS3Mock.java
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/delta-s3
branch
from
9ac1938 to
a3b029a
Compare
Member
Author
|
Currently, based on #27374 to avoid conflicts. |
findepi
force-pushed
the
findepi/delta-s3
branch
from
a3b029a to
4517de7
Compare
findepi
force-pushed
the
findepi/delta-s3
branch
from
4517de7 to
25521e1
Compare
findepi
commented
Nov 21, 2025
lib/trino-filesystem-s3/src/test/java/io/trino/filesystem/s3/TestS3FileSystemS3Mock.java
Show resolved
Hide resolved
losipiuk
reviewed
Nov 21, 2025
It missed an update when `S3ConditionalWriteLogSynchronizer` was introduced. Key points - s3 log synchronization leveraging conditional writes is available out of the box, does not require `delta.enable-non-concurrent-writes` property - the old mode (implemented by S3LockBasedTransactionLogSynchronizer) is not compatible with the new mode - document how those modes exactly work, as it is important for users to understand different engines compatibilities. how log writes are orchestrated is not an implementation detail
Upgrade S3Mock to a version supporting S3 conditional writes. Unfortunately, conditional multi-part writes do not work correctly in S3Mock.
findepi
force-pushed
the
findepi/delta-s3
branch
from
c036c9b to
11e34a7
Compare
losipiuk
reviewed
Nov 21, 2025
lib/trino-filesystem-s3/src/main/java/io/trino/filesystem/s3/S3FileSystemConfig.java
Show resolved
Hide resolved
losipiuk
approved these changes
Nov 21, 2025
`s3.exclusive-create` config is informative and only consumed by Delta Lake connector. Replace it with a new connector's specific config (`delta.s3.transaction-log-conditional-writes.enabled`). This follows earlier change, commit d3a7fd5, where the S3 config was made informative only.
findepi
force-pushed
the
findepi/delta-s3
branch
from
11e34a7 to
05948bb
Compare
Contributor
|
@findepi For the release notes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s3.exclusive-createconfig is informative and only consumed by DeltaLake connector. Replace it with a new connector's specific config
(
delta.s3.transaction-log-conditional-writes.enabled).This follows earlier change, commit
d3a7fd5 (#27330), where the S3 config was made
informative only.
Release notes considerations
s3.exclusive-createconfig removeds3.exclusive-createconfig renamed todelta.s3.transaction-log-conditional-writes.enabled