Skip underlying query analysis if MV is fresh #27551
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrrzysko
force-pushed
the
skip_analysis_fresh_mv
branch
from
03755cf to
ef76b29
Compare
Since 4349aa9, the test_materialized_view_stale used in TestEventListenerBasic had not been considered stale, because MockConnector did not treat an MV with a storage table as stale. This commit introduces a way to explicitly define the freshness of an MV in MockConnector.
Analyzing the underlying query can be costly in some scenarios, especially when it references many tables. An additional benefit of skipping this analysis is improved availability — MV data sources don’t need to be reachable when accessing the MV.
piotrrzysko
force-pushed
the
skip_analysis_fresh_mv
branch
from
ef76b29 to
2f2583f
Compare
Member
"Improve performance ..." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Analyzing the underlying query can be costly in some scenarios, especially when it references many tables. An additional benefit of skipping this analysis is improved availability - MV data sources don’t need to be reachable when accessing the MV.
Additional context and related issues
We are working on adding a
WHEN STALEclause toCREATE MATERIALIZED VIEW. Relevant PRs:WHEN STALEsyntax forCREATE MATERIALIZED VIEW#27356WHEN STALEin analyzer #27502The change proposed in this PR makes the definitions of the behaviors controlled by the new clause simpler and more symmetric; see this comment: #27356 (comment).
Additionally, it brings the current MV implementation closer to resolving #23387 (reply in thread) and #23747.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: