Skip to content

Comments

changes: Post zenith audit changes summary#5

Open
akiraonstarknet wants to merge 1 commit intozenith-auditedfrom
post-zenith-audited-changes
Open

changes: Post zenith audit changes summary#5
akiraonstarknet wants to merge 1 commit intozenith-auditedfrom
post-zenith-audited-changes

Conversation

@akiraonstarknet
Copy link

@akiraonstarknet akiraonstarknet commented Oct 13, 2025

The changes have been done on original starknet vault kit repo itself, but this PR is meant to simply analyse those changes in a easy way. From our end, a few changes include in Sanitizer contracts which are view only contracts that don't change the state of vault and related contracts. Sanitizers are like dynamic logics that allow admins of the vault to config permissions on allowed operations on funds.

Official branch used for looping strategies: loopers (https://github.com/trovesfi/starknet_vault_kit/blob/loopers/). The base of loopers branch is created from this commit from original repo: ForgeYields@43c8fe4
The post-zenith-audited-changes has same changes, but simplied for PR purposes to allow you to transparently see the diff.

How to verify class hash:

  1. Fork into branch post-zenith-audited-changes
  2. Install scarb 2.12.2
  3. cd scripts
  4. Pass package and contract name to verify. e.g. npx tsx cli.ts compile --package vault --contract Vault

Key changes:

Vault

  1. Add functions to allow setting of Deposit/withdraw limits
  2. bring_liquidity: Add caller assert (Zenith audit issue) + Emit bring liquidity emit

Redeem Request NFT

Only adds ERC721EnumerableComponent of OZ to provide Enumerability feature

Manager contract

No additions, just removed flash loan feature from Vesu

Vault Allocator

No changes

Copilot AI review requested due to automatic review settings October 13, 2025 05:59
@akiraonstarknet akiraonstarknet changed the title changes changes: Post zenith audit changes summary Oct 13, 2025

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant