changes: Post zenith audit changes summary#5
Open
akiraonstarknet wants to merge 1 commit intozenith-auditedfrom
Open
changes: Post zenith audit changes summary#5akiraonstarknet wants to merge 1 commit intozenith-auditedfrom
akiraonstarknet wants to merge 1 commit intozenith-auditedfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes have been done on original starknet vault kit repo itself, but this PR is meant to simply analyse those changes in a easy way. From our end, a few changes include in Sanitizer contracts which are view only contracts that don't change the state of vault and related contracts. Sanitizers are like dynamic logics that allow admins of the vault to config permissions on allowed operations on funds.
Official branch used for looping strategies: loopers (https://github.com/trovesfi/starknet_vault_kit/blob/loopers/). The base of loopers branch is created from this commit from original repo: ForgeYields@43c8fe4
The post-zenith-audited-changes has same changes, but simplied for PR purposes to allow you to transparently see the diff.
How to verify class hash:
npx tsx cli.ts compile --package vault --contract VaultKey changes:
Vault
Redeem Request NFT
Only adds ERC721EnumerableComponent of OZ to provide Enumerability feature
Manager contract
No additions, just removed flash loan feature from Vesu
Vault Allocator
No changes