Skip to content

Upgrade/scarb 2.11.4#22

Open
akiraonstarknet wants to merge 7 commits intomainfrom
upgrade/scarb-2.11.4
Open

Upgrade/scarb 2.11.4#22
akiraonstarknet wants to merge 7 commits intomainfrom
upgrade/scarb-2.11.4

Conversation

@akiraonstarknet
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings September 20, 2025 23:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades Scarb from version 2.8.4 to 2.11.4, updating various dependencies and tooling versions to maintain compatibility. The upgrade includes updates to Alexandria libraries, OpenZeppelin contracts, Ekubo protocol dependencies, and Starknet Foundry testing framework.

Key changes include:

  • Dependency version updates for core libraries (OpenZeppelin, Alexandria, Ekubo, Starknet Foundry)
  • Addition of a new AumOracle contract for asset under management reporting
  • Test configuration updates to use specific block numbers instead of "mainnet_latest"

Reviewed Changes

Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Scarb.toml Updates package version and all dependency versions for Scarb 2.11.4 compatibility
.tool-versions Updates Scarb and Starknet Foundry tool versions
src/peripheral/aum_oracle.cairo Adds new AumOracle contract with access control and vault reporting functionality
src/lib.cairo Adds peripheral module declaration for new contracts
src/strategies/vesu_rebalance/test.cairo Updates fork configuration and adds new contract address for testing
scripts/vesu_rebalance/actions.ts Modifies harvest execution to split calls into batches
scripts/peripherals/deploy_aum_oracle.ts Adds deployment script for AumOracle contract
package.json Updates @strkfarm/sdk dependency version
contracts.json Adds AumOracle class hash and contract addresses
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


/// Retrieves the address of the vault contract.
fn get_vault_address(self: @TContractState) -> starknet::ContractAddress;

Copy link

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function lacks documentation. Add a docstring explaining the purpose, parameters, and behavior of the health factor assertion.

Suggested change
/// Asserts that the user's health factor in the specified Vesu pool is within the given bounds.
///
/// # Parameters
/// - `vesu_singleton`: The address of the Vesu singleton contract.
/// - `pool_id`: The identifier of the pool to check.
/// - `collateral`: The address of the collateral token.
/// - `debt`: The address of the debt token.
/// - `user`: The address of the user whose health factor is being checked.
/// - `min_hf`: The minimum allowed health factor.
/// - `max_hf`: The maximum allowed health factor.
///
/// # Behavior
/// Checks the user's health factor in the specified pool and asserts that it is within the [min_hf, max_hf] range.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants