Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Scarb from version 2.8.4 to 2.11.4, updating various dependencies and tooling versions to maintain compatibility. The upgrade includes updates to Alexandria libraries, OpenZeppelin contracts, Ekubo protocol dependencies, and Starknet Foundry testing framework.
Key changes include:
- Dependency version updates for core libraries (OpenZeppelin, Alexandria, Ekubo, Starknet Foundry)
- Addition of a new AumOracle contract for asset under management reporting
- Test configuration updates to use specific block numbers instead of "mainnet_latest"
Reviewed Changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Scarb.toml | Updates package version and all dependency versions for Scarb 2.11.4 compatibility |
| .tool-versions | Updates Scarb and Starknet Foundry tool versions |
| src/peripheral/aum_oracle.cairo | Adds new AumOracle contract with access control and vault reporting functionality |
| src/lib.cairo | Adds peripheral module declaration for new contracts |
| src/strategies/vesu_rebalance/test.cairo | Updates fork configuration and adds new contract address for testing |
| scripts/vesu_rebalance/actions.ts | Modifies harvest execution to split calls into batches |
| scripts/peripherals/deploy_aum_oracle.ts | Adds deployment script for AumOracle contract |
| package.json | Updates @strkfarm/sdk dependency version |
| contracts.json | Adds AumOracle class hash and contract addresses |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| /// Retrieves the address of the vault contract. | ||
| fn get_vault_address(self: @TContractState) -> starknet::ContractAddress; | ||
|
|
There was a problem hiding this comment.
This function lacks documentation. Add a docstring explaining the purpose, parameters, and behavior of the health factor assertion.
Suggested change
| /// Asserts that the user's health factor in the specified Vesu pool is within the given bounds. | |
| /// | |
| /// # Parameters | |
| /// - `vesu_singleton`: The address of the Vesu singleton contract. | |
| /// - `pool_id`: The identifier of the pool to check. | |
| /// - `collateral`: The address of the collateral token. | |
| /// - `debt`: The address of the debt token. | |
| /// - `user`: The address of the user whose health factor is being checked. | |
| /// - `min_hf`: The minimum allowed health factor. | |
| /// - `max_hf`: The maximum allowed health factor. | |
| /// | |
| /// # Behavior | |
| /// Checks the user's health factor in the specified pool and asserts that it is within the [min_hf, max_hf] range. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.