Skip to content

bugfix: fix the typos in trpc-jave-demo's yaml #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gbccccc
Copy link

@gbccccc gbccccc commented May 17, 2025

When trying to run the ClientTest of trpc-java-demo, I got the following error

java.lang.IllegalStateException: Yaml config parse exception, position(client->service), interface name is com.tencent.trpc.demo.proto.GreeterserviceAPI
        at com.tencent.trpc.container.config.yaml.BackendConfigParser.loadClass(BackendConfigParser.java:86) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.container.config.yaml.BackendConfigParser.lambda$parseConfig$0(BackendConfigParser.java:70) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]     
        at java.util.Optional.map(Optional.java:260) ~[?:?]
        at com.tencent.trpc.core.utils.BinderUtils.bind(BinderUtils.java:160) ~[trpc-core-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.core.utils.BinderUtils.bind(BinderUtils.java:144) ~[trpc-core-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.container.config.yaml.BackendConfigParser.parseConfig(BackendConfigParser.java:69) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]
        at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?]
        at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625) ~[?:?]
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
        at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) ~[?:?]
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
        at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?]
        at com.tencent.trpc.container.config.yaml.BackendConfigParser.parseConfigMap(BackendConfigParser.java:47) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.container.config.yaml.ClientConfigParser.parseClientConfig(ClientConfigParser.java:42) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.container.config.ApplicationConfigParser.doParse(ApplicationConfigParser.java:86) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.container.config.ApplicationConfigParser.parse(ApplicationConfigParser.java:41) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.container.container.DefaultContainer.start(DefaultContainer.java:37) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.server.container.TRPC.start(TRPC.java:32) [trpc-server-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.server.main.Main.main(Main.java:36) [trpc-server-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.demo.example.yaml.ClientTest.main(ClientTest.java:32) [classes/:?]
        at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:279) [exec-maven-plugin-3.1.0.jar:?]
        at java.lang.Thread.run(Thread.java:842) [?:?]

After checking, I found some typos for interface names in trpc_java_client.yaml. The interface names don't match those defined in the demo.proto

Copy link

github-actions bot commented May 17, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link

codecov bot commented May 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13154%. Comparing base (33f8bfb) to head (6f7b00a).

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##                master         #82         +/-   ##
=====================================================
- Coverage     70.21339%   70.13154%   -0.08186%     
+ Complexity        4253        4240         -13     
=====================================================
  Files              437         437                 
  Lines            17105       17105                 
  Branches          1727        1727                 
=====================================================
- Hits             12010       11996         -14     
- Misses            3986        3993          +7     
- Partials          1109        1116          +7     

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbccccc
Copy link
Author

gbccccc commented May 17, 2025

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant