Skip to content

Conversation

@Paladynee
Copy link

i just cloned the repo and immediately got hit with a thousand compile errors and rust analyzer not working. i PR'd the changes i currently have.

please tell me if the pathmap dependency is actually https://github.com/Adam-Vandervorst/PathMap blind-zippers.

@Paladynee Paladynee changed the title relax inline bounds, relax static bound, suppress warnings relax inline attributes, relax static bound, suppress warnings Nov 14, 2025
@Adam-Vandervorst
Copy link
Collaborator

Are you building MORK in the kernel directory?
Can you share the benchmark results motivating the inlining changes?
Rest LGTM.

@Paladynee
Copy link
Author

Paladynee commented Nov 15, 2025

i currently can't build the project, because i still don't have the specific commit of PathMap or the correct branch. im in the workspace root, not in any specific workspace member

you can cherry pick the inline relaxation as i don't have any benchmarks to back my results, but the rule of thumb is to accompany the inline(always) with a link to the benchmark results that does prove the increased performance https://nnethercote.github.io/perf-book/inlining.html. bloating the icache is not always the best solution to perf

@Paladynee
Copy link
Author

Paladynee commented Nov 15, 2025

error[E0432]: unresolved import `freeze`
    --> expr/src/main.rs:1119:5
     |
1119 | use freeze::{LiquidVecRef, BumpAllocRef};
     |     ^^^^^^ use of unresolved module or unlinked crate `freeze`
     |
     = help: if you wanted to use a crate named `freeze`, use `cargo add freeze` to add it to your `Cargo.toml`

For more information about this error, try `rustc --explain E0432`.

I'm currently in the main branch and i have pathmap in ../PathMap with the latest blind-zippers branch, and i'm getting this and many more unresolved imports errors, such as use pathmap::trie_map::BytesTrieMap;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants