Open
Conversation
Co-authored-by: Sagar Adhikari <[email protected]>
* added: driver type data * feat: added client side pages and components --------- Co-authored-by: Sagar Adhikari <[email protected]>
* added: driver type data * feat: added client side pages and components * admin-dashboard-updated --------- Co-authored-by: Sagar Adhikari <[email protected]>
* fixed: user registration * feat: added a custom json for testing --------- Co-authored-by: Rahul Mijar <[email protected]>
* added: driver type data * feat: added client side pages and components * admin-dashboard-updated * jsondb_updated * map_integrated * fixed:registration and added a login feature * table created * driver_api_created * fixed : driver_table _fixed * added some changes in admin side UI --------- Co-authored-by: Sagar Adhikari <[email protected]> Co-authored-by: Rahul Mijar <[email protected]>
ravigrauniyar
suggested changes
Feb 23, 2024
masm smm m
Outdated
| import Home from "./client/pages/Home"; | ||
| import Contact from "./client/pages/Contact"; | ||
| import Register from "./client/pages/Register"; | ||
| // import Register from "./client/pages/Register"; |
src/Storemanagement/Store.ts
Outdated
| @@ -0,0 +1,14 @@ | |||
|
|
|||
| import{ create} from 'zustand'; | |||
|
|
|||
There was a problem hiding this comment.
Let's avoid unnecessary spacing.
| @@ -0,0 +1,22 @@ | |||
| /* eslint-disable react-hooks/rules-of-hooks */ | |||
There was a problem hiding this comment.
Don't use hooks here. Follow rules of hook and pass "repo" as a prop to this function.
| @@ -0,0 +1,105 @@ | |||
| // import { useRepository } from '@/hooks/CustomHook'; | |||
There was a problem hiding this comment.
Delete this file and any other file with commented code only.
| } | ||
| // Configure options for the request | ||
| const requestOption: RequestInit = { | ||
| // if(body){ |
| {/* Optimize image by specifying dimensions and loading it lazily */} | ||
| <img | ||
| src="banner.png" | ||
| alt="" |
| navigate("/checkOtp", { | ||
| state: { confirmed: confirmation, phone: phone }, | ||
| }); | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any |
There was a problem hiding this comment.
Avoid using eslint-disable from every place.
| @@ -1,24 +1,16 @@ | |||
| // LocalStorageClient.ts | |||
There was a problem hiding this comment.
If we're not using this Class through Provider and context, let's delete it.
| @@ -1,7 +1,5 @@ | |||
| export declare interface IStorageClient { | |||
| import { useRepository } from "@/hooks/CustomHook"; | ||
| import { OnlineDriver } from "@/types/data"; | ||
| import _ from "lodash"; | ||
| import { useEffect, useState } from 'react'; |
There was a problem hiding this comment.
Aren't these throwing errors? "useEffect" and "useState" are hooks and can't be used here. Just return the response data received.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.