Update compute-pcrs to latest version #152
Conversation
Minimum rust version was set to 1.85. Fedora is way above that threshold at the moment. Future EL releases will be above that as well. While on it, fix some of the linter errors that arise from the minimum version update. Signed-off-by: Beñat Gartzia Arruabarrena <[email protected]>
And update those crates that were making use of it. Later we will also use it in some other crates. Signed-off-by: Beñat Gartzia Arruabarrena <[email protected]>
I broke some of the compute-pcrs' lib APIs, so apart from just pointing into a newer commit, we also need to tweak a couple of things here and there. Signed-off-by: Beñat Gartzia Arruabarrena <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bgartzi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@bgartzi: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
cc @Jakob-Naucke, updating compute-pcrs in this PR so we can tell dependabot to unignore it before I forget. I'm still working on integration tests for #116 meanhwile. |
|
Sorry for the noise @Jakob-Naucke, we will need to wait for yet another fix in the compute-pcrs lib. At least if we aim to implement an integration test that considers adding an approved image that is fcos > 42 (trusted-execution-clusters/compute-pcrs#60), which we need if we want different shim grub and kernel compared to the 42 images integration tests are currently using. |
|
The fix is not needed (yet) as long as we're trying to test against an image fetched from the stable fcos stream. That's the case, as I will be probably targetting So no further concerns from my side for this PR, unless there's some on your side. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
This PR splits #116 into two. That PR updated the compute pcrs library to the latest available version, and tweaked some things in the operator due to the API breakage I caused in the library.
It was the reason why dependabot could not successfully upgrade the version by itself in #121
Even if #116 depends on these changes and also introduces them, it will probably take a bit longer to merge, as it needs some integration test coverage, among others.
Meanwhile, it is a good idea I think to update compute-pcrs and tell dependabot to unignore the package, as I could forget about it in the future.
Note that this PR also upgrades the minimum supported rust-version from
1.85to1.88.